[NFC] Fix an incorrect comment about operator precedence. #105784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment talks about left-associative operators twice, when the latter mention is actually describing right-associative operators.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Michael Park (mpark) ChangesThe comment talks about left-associative operators twice, when the latter mention is actually describing right-associative operators. Full diff: https://github.com/llvm/llvm-project/pull/105784.diff 1 Files Affected:
diff --git a/clang/lib/Parse/ParseExpr.cpp b/clang/lib/Parse/ParseExpr.cpp
index 1405aef700bec5..64f284d78b24db 100644
--- a/clang/lib/Parse/ParseExpr.cpp
+++ b/clang/lib/Parse/ParseExpr.cpp
@@ -607,7 +607,7 @@ Parser::ParseRHSOfBinaryExpression(ExprResult LHS, prec::Level MinPrec) {
RHS = ExprError();
}
// If this is left-associative, only parse things on the RHS that bind
- // more tightly than the current operator. If it is left-associative, it
+ // more tightly than the current operator. If it is right-associative, it
// is okay, to bind exactly as tightly. For example, compile A=B=C=D as
// A=(B=(C=D)), where each paren is a level of recursion here.
// The function takes ownership of the RHS.
|
cor3ntin
approved these changes
Aug 23, 2024
Contributor
cor3ntin
left a comment
cor3ntin
left a comment
There was a problem hiding this comment.
Thanks (Hi!). Do you have commit access or should I merge that for you?
Member
Author
Hi Corentin! I have commit access 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment talks about left-associative operators twice, when the latter mention is actually describing right-associative operators.